Monday, December 26, 2011

Dec.26's Nov.29 Code Review update

General updates:
  • in tests put constant first so never accidental assignment (if (0==x)... )
  • use simple types (int, unsigned int, bool, etc) instead of forte or cyg types
    • Changing cyg_bool to bool caused motors to stop working since cyg_bool=int
  • static variables  in .cpp should be private member variables in h file
    • when static variable address is passed to thread it must be in .cpp file 
    • still looking for more eloquent way to do this
  • if return will never be checked, then return changed to void
  • delete extra comments with background information only
    Not yet implemented:
    • rename L_AD (analog digital sensor) to L_AI (analog sensor input)
    • rename L_LED (sensor led output) to L_DO (digital sensor output)
    • change from F_GT_UNIT to ../IEC61131-3/Functions/SelectionComparison/Comparison/F_GT 
      • Using Forte-IDE 1.0 due bugs in dev IDE which cause types to disapper
    Partly implemented:
    • use { }s for all if and else causes, so to prevent possible errors from  debug print
    Additional updates: 
    • Changed motor max to 3 from 4 and padded the AVR buffer by 1.

      No comments:

      Post a Comment