Code clean-up time.
AVR Control class still needs some more clean-up, but otherwise FBs are used now.
1. CL_Button and CL_SensorPortMgr are now in associated FBs and tested.
Our good friend blinky is deleted.
Means you have to guess when you can start the eth_serial communication, but even with blinky it was possible to start it too soon.
Using the include define flag didn't work because of the order of compiling.
But handcoding one so if no Button FB , buttons are not polled, which make Button FB not always required
saves 2536 bytes. We have enough space at moment, but that's alot isn't?
*2. Should all FBs that don't do port checking (L_LED, L_TOUCH, L_SOUND) be:
- deleted
- go in different pallette
- be kept and go in the same pallette
???
They are slightly smaller since not composite FBs, but would not be considered safe.
3. Can LMS device wide constants go in LMS_DEV?
like max motors and max sensors? in multiple places at the moment and shouldn't be.
supported sensor list?
After avr ctl is cleaned up, do its methods really belong in the LMS device?
Its not a sub-device, its part of the LMS device.
4. Comments and clean-up
tabs - have to set for every type editor!!! Hope I got them all.
Made more things private in various classes
Either deleted extra comments or added a TODO or TOFIX to explain why didnt want to lose the info.
Added a few more checks for the motor including extra FBs for port checking
LC_M_PWR with port checking and L_M_PORT FB
No comments:
Post a Comment